FIX catch writing of pcs #442
Conversation
Codecov Report
@@ Coverage Diff @@
## development #442 +/- ##
==============================================
+ Coverage 86.33% 86.9% +0.56%
==============================================
Files 50 51 +1
Lines 3608 4070 +462
==============================================
+ Hits 3115 3537 +422
- Misses 493 533 +40
Continue to review full report at Codecov.
|
smac/utils/io/output_writer.py
Outdated
| new_path = os.path.join(scenario.output_dir_for_this_run, 'configspace.pcs') | ||
| self.save_configspace(scenario.cs, new_path, 'pcs_new') | ||
| except TypeError: | ||
| traceback.print_exc() |
There was a problem hiding this comment.
I think this output should be sent to the logger with level ERROR.
There was a problem hiding this comment.
that's what I tried but unfortunately, somehow at some point we try to serialize this class such that we cannot have a logger here.
There was a problem hiding this comment.
You can use this helper class to make the logger pickleable: https://github.com/automl/SMAC3/blob/development/smac/utils/logging.py
|
@mfeurer Ready for merge? |
Writing the cs in pcs can fail if not all parameter values of cat parameter are strings. The json format can deal with it. Therefore, I added a catch and try block to prevent SMAC from crashing.