ci: Remove unnecessary Python setup step #285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
I could've opened a separate issue, but I figured a PR makes it easier to view my suggestion.
What does this implement/fix? Explain your changes.
When looking at this workflow I noticed that there seems to be an extraneous Python setup step in the citizen bump job. As far as I can tell, it serves no purpose. In my work-in-progress workflow I left it out without issue.
Minimal Example / How should this PR be tested?
Run the workflow (on a fork where it is not a trusted PyPI publisher...). I tried it here, but unfortunately the docs step already seems to be failing, so it won't show a successful bump. So that step would need to be resolved first, but it's unrelated to this PR. After that, you should see that indeed the Python setup step is not necessary to execute the bump job and you can release 23 seconds faster. Nifty.
Any other comments?
Made the change from the browser, so it did bypass pre-commit. I assume there is a pre-commit CI running so that if there's a problem it'll be detected before a merge anyway.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.