Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add's an isort check #1326

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Add's an isort check #1326

merged 1 commit into from
Dec 1, 2021

Conversation

eddiebergman
Copy link
Contributor

  • Adds an isort check for import in the autosklearn folder
    • This excludes test folders.
  • Adds recurse submodules to the black_checker.yml as well, does not harm and will update it for when using the automl_common submodule.

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #1326 (0806a9b) into development (3761f9b) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1326      +/-   ##
===============================================
+ Coverage        88.05%   88.12%   +0.06%     
===============================================
  Files              140      140              
  Lines            11163    11163              
===============================================
+ Hits              9830     9837       +7     
+ Misses            1333     1326       -7     
Impacted Files Coverage Δ
autosklearn/evaluation/abstract_evaluator.py 93.05% <0.00%> (+0.77%) ⬆️
...learn/pipeline/components/regression/libsvm_svr.py 91.46% <0.00%> (+1.21%) ⬆️
...mponents/feature_preprocessing/nystroem_sampler.py 91.17% <0.00%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3761f9b...0806a9b. Read the comment docs.

Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this (and black) be moved into the pre-commit? This would reduce the amount of actions and simplify the usage for the user. Might not be possible, though, because they're not allowed to fail right now.

@eddiebergman
Copy link
Contributor Author

I couldn't find anything that allows for failed steps at a glance. While I could stick them into new sections in the pre-commit workflow, as they are at the moment, perhaps we wait until the code base is black'ed and isort'ed?

@eddiebergman eddiebergman merged commit 1901b1c into development Dec 1, 2021
github-actions bot pushed a commit that referenced this pull request Dec 1, 2021
@mfeurer
Copy link
Contributor

mfeurer commented Dec 1, 2021

While I could stick them into new sections in the pre-commit workflow, as they are at the moment, perhaps we wait until the code base is black'ed and isort'ed?

Yep, let's just wait.

@mfeurer mfeurer deleted the pr_isort_check branch December 1, 2021 09:31
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
eddiebergman added a commit that referenced this pull request Jan 25, 2022
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
eddiebergman added a commit that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants