-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add's an isort check #1326
Add's an isort check #1326
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1326 +/- ##
===============================================
+ Coverage 88.05% 88.12% +0.06%
===============================================
Files 140 140
Lines 11163 11163
===============================================
+ Hits 9830 9837 +7
+ Misses 1333 1326 -7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this (and black) be moved into the pre-commit? This would reduce the amount of actions and simplify the usage for the user. Might not be possible, though, because they're not allowed to fail right now.
I couldn't find anything that allows for failed steps at a glance. While I could stick them into new sections in the pre-commit workflow, as they are at the moment, perhaps we wait until the code base is black'ed and isort'ed? |
Yep, let's just wait. |
isort
check for import in theautosklearn
folderblack_checker.yml
as well, does not harm and will update it for when using theautoml_common
submodule.