-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update warnings #1338
Merged
mfeurer
merged 7 commits into
fix_regression_algorithms_y_dimensions
from
update_warnings
Dec 14, 2021
Merged
Update warnings #1338
mfeurer
merged 7 commits into
fix_regression_algorithms_y_dimensions
from
update_warnings
Dec 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## fix_regression_algorithms_y_dimensions #1338 +/- ##
===========================================================================
+ Coverage 24.74% 87.92% +63.18%
===========================================================================
Files 140 140
Lines 10977 10977
===========================================================================
+ Hits 2716 9652 +6936
+ Misses 8261 1325 -6936
Continue to review full report at Codecov.
|
mfeurer
changed the base branch from
development
to
fix_regression_algorithms_y_dimensions
December 10, 2021 08:44
mfeurer
reviewed
Dec 10, 2021
mfeurer
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off the warngings file created in #1335, should be merged after that.
This PR introduces a few more warning catches and adds more warning catches throughout the test files.