Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dependancies warnings introduced by sphinx_toolbox #1339

Merged
merged 3 commits into from
Dec 9, 2021

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Dec 8, 2021

PR #1309 introduced the docs dependancy sphinx_toolbox, checking it's requirements, it relies on locked versions of docutils and sphinx.

This PR removed the warnings by locking the docutils version to 0.16 and sphinx to <4.3.

It also fixes the build warning message that seems to have appeared. This is done by setting and checking environment variables in conf.py instead of using the -D option of sphinx

The config value plot_gallery has type str, defaults to bool.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #1339 (8d578e4) into development (b90c228) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1339   +/-   ##
============================================
  Coverage        87.90%   87.91%           
============================================
  Files              140      140           
  Lines            10938    10938           
============================================
+ Hits              9615     9616    +1     
+ Misses            1323     1322    -1     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
...ine/components/classification/gradient_boosting.py 93.04% <0.00%> (-0.87%) ⬇️
autosklearn/evaluation/abstract_evaluator.py 93.05% <0.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90c228...8d578e4. Read the comment docs.

@eddiebergman eddiebergman merged commit a2f7ca2 into development Dec 9, 2021
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
eddiebergman added a commit that referenced this pull request Jan 25, 2022
* Added versioning for sphinx, docutils - introduced by sphinxtoolbox

* Fixed bug with config value for `plot_gallery` in doc makefile

* Update linkcheck command as well
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
@eddiebergman eddiebergman deleted the update_requirements_for_sphinx_toolbox branch February 9, 2022 14:27
eddiebergman added a commit that referenced this pull request Aug 18, 2022
* Added versioning for sphinx, docutils - introduced by sphinxtoolbox

* Fixed bug with config value for `plot_gallery` in doc makefile

* Update linkcheck command as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants