-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools update #1358
Merged
Merged
Tools update #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1358 +/- ##
===============================================
- Coverage 87.95% 0 -87.96%
===============================================
Files 140 0 -140
Lines 10959 0 -10959
===============================================
- Hits 9639 0 -9639
+ Misses 1320 0 -1320 |
9 tasks
eddiebergman
added a commit
that referenced
this pull request
Feb 7, 2022
eddiebergman
added a commit
that referenced
this pull request
Feb 8, 2022
eddiebergman
added a commit
that referenced
this pull request
Aug 18, 2022
* Draft tidy of workflows * Fix: mypy should not ignore missing imports * Added pydocstyle to checkers * Added check and format make options * Fix: mutiple entries in same line setup.py * Change: black line length to 88 * Fix: make check to only perform checks * Update: Flake8 ignores style (handled by black/isort) * Add: pydocstyle, disabled in pre-commit * Add: Makefile `make pre-commit` * Fix: Ignores for mypy on untyped modules * Limit scope of pre-commit steps * Fix: flake8 no longer concerned about line length * Add: Flake8 to `make check` * Fix: reduce scope of black and isort * Fix: Pydocstyle now uses numpy convention * Fix: workaround for test imports of `automl_common` * Fix: `mypy` ignores `automl_common` now * Fix: Limit scope of `black` and `isort` formatting * Fix: pre-commit performs no file changes now * Add: `make pre-commit` to `make help` * Fix: `make help` docstring for `make pre-commit` * Fix: isort update sections autosklearn, types * Fix: warnings by flake8 for line length * Fix: Types section for isort * Fix: reenable `flake8` formatting checking * Update: flake8 to use black's line length of 88 * add: ignore D205 pydocstyle * Fix: Import order for futures * Fix: flake8 ignore E203 * Fix: Formatting and fixed long lines * Del: black/isort checker, checked with pre-commit * Fix: test dummy prediction error msg * Add: `coverage` to `pyproject.yaml` * Add: coverage ignore for `if TYPE_CHECKING` * Fix: missing coma * Fix: `toml` dependency for pydoctyle in pre-commit * Fix: isort src path * Add: `make test` * Fix: Add name of module to check coverage of * Maint: isort and black most recent dev * Fix: import typo * Change: format now performs individually on each directory
eddiebergman
added a commit
that referenced
this pull request
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates several aspects of the tools surrounding development on
autosklearn
as part of the "black and isort" major change. Most of the configuration for things can be found inpyproject.toml
and are documented where non-obvious.Reminder: Add attribution for @isaac-chung
These checks will fail but running
make format
will fix all files so that that it will pass thesepre-commit
checks. They have been left unformatted to keep the PR clean and reviewable.TODO: Update Contribution Guide in light of these changes
black
andisort
.88
in accordance with usual black'nd libraries.pre-commit
pydocstyle
, however this is disabled for now as almost all modules fail this check.pyproject.toml
)numpy
style (the one we use)mypy
andpytest
configurations were moved to the newpyproject.toml
along with theblack
,pydocstyle
andisort
configurations.testcommand.sh
, seems like a stray file.coverage.yml
which controls our automatic code coverage checks through github actions.50%
->0.2%
.87%
to match current test coverage90%
testedcode-cov
, this will likely drop our coverage but indicate branches that were not taken.pre-commit
now includes the aforementioned formatters and checkers. The packages were also updated to their latest versions.Makefile
was remade to perform many of these commands and others. This should make it easier to perform the relevant commands as well as make it easier for new contributors to use our workflows. Notably:publish
only publishes to the test servers but prints instructions for the real one after advising that the test distribution be pip installed and tested first.