Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make SimpleClassificationPipeline tests deterministic #1366

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Jan 11, 2022

Fixes some nondeterminism in testing SimpleClassificationPipeline as a whole, does not change the non-deterministic of testing randomly sampled configurations.

Failing Test: https://github.com/automl/auto-sklearn/runs/4767926218?check_suite_focus=true

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #1366 (fd674bb) into development (b01c732) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1366   +/-   ##
============================================
  Coverage        87.97%   87.98%           
============================================
  Files              140      140           
  Lines            10993    10993           
============================================
+ Hits              9671     9672    +1     
+ Misses            1322     1321    -1     
Impacted Files Coverage Δ
...ine/components/classification/gradient_boosting.py 92.98% <0.00%> (-0.88%) ⬇️
autosklearn/evaluation/abstract_evaluator.py 92.27% <0.00%> (-0.78%) ⬇️
...eline/components/feature_preprocessing/fast_ica.py 97.82% <0.00%> (+6.52%) ⬆️
...ponents/feature_preprocessing/select_percentile.py 92.30% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01c732...fd674bb. Read the comment docs.

@eddiebergman
Copy link
Contributor Author

Appears failing tests are due to the MLP classifier being non-deterministic. Will handle these in a seperate PR.

@eddiebergman eddiebergman merged commit f5964ca into development Jan 12, 2022
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
@eddiebergman eddiebergman deleted the fix_random_state_simple_pipeline branch February 9, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant