Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MLPRegressor tests #1367

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Fix: MLPRegressor tests #1367

merged 3 commits into from
Jan 12, 2022

Conversation

eddiebergman
Copy link
Contributor

Seems there's been more numerical instability with MLPRegressor. I did a pass over any new source of nondeterminism but could find none.

I've updated the values and started documenting new values that appear while still allowing tests to pass. It seems iterative_fit may be the culprit.

Failing tests: https://github.com/automl/auto-sklearn/runs/4778346386?check_suite_focus=true

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1367 (8b81345) into development (b01c732) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 8b81345 differs from pull request most recent head 4a891b6. Consider uploading reports for the commit 4a891b6 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1367      +/-   ##
===============================================
+ Coverage        87.97%   88.03%   +0.06%     
===============================================
  Files              140      140              
  Lines            10993    10993              
===============================================
+ Hits              9671     9678       +7     
+ Misses            1322     1315       -7     
Impacted Files Coverage Δ
autosklearn/evaluation/abstract_evaluator.py 92.27% <0.00%> (-0.78%) ⬇️
..._preprocessing/select_percentile_classification.py 91.52% <0.00%> (+1.69%) ⬆️
autosklearn/pipeline/components/regression/mlp.py 95.31% <0.00%> (+3.12%) ⬆️
...eline/components/feature_preprocessing/fast_ica.py 97.82% <0.00%> (+6.52%) ⬆️
...ponents/feature_preprocessing/select_percentile.py 92.30% <0.00%> (+7.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b01c732...4a891b6. Read the comment docs.

@eddiebergman eddiebergman merged commit b58be50 into development Jan 12, 2022
github-actions bot pushed a commit that referenced this pull request Jan 12, 2022
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
eddiebergman added a commit that referenced this pull request Jan 25, 2022
* Fix: MLPRegressor tests

* Fix: Ordering of statements in test

* Fix: MLP n_calls
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
@eddiebergman eddiebergman deleted the fix_mlp_tests branch February 9, 2022 14:27
eddiebergman added a commit that referenced this pull request Aug 18, 2022
* Fix: MLPRegressor tests

* Fix: Ordering of statements in test

* Fix: MLP n_calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant