Fix: kernal pca config error with sparse data #1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems kernel_pca emits the error: * `"zero-size array to reduction operation maximum which has no identity"` This is gotten on the line `max_eig = lambdas.max()` which makes me assume it emits a matrix with no real eigen values, not something we can really control for
Codecov Report
@@ Coverage Diff @@
## development #1368 +/- ##
===============================================
- Coverage 87.99% 87.95% -0.04%
===============================================
Files 140 140
Lines 10993 10993
===============================================
- Hits 9673 9669 -4
- Misses 1320 1324 +4
Continue to review full report at Codecov.
|
Merged
eddiebergman
added a commit
that referenced
this pull request
Jan 25, 2022
* Fix: Raises errors with the config * Add: Skip error for kernal_pca Seems kernel_pca emits the error: * `"zero-size array to reduction operation maximum which has no identity"` This is gotten on the line `max_eig = lambdas.max()` which makes me assume it emits a matrix with no real eigen values, not something we can really control for
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems kernel_pca emits the error:
"zero-size array to reduction operation maximum which has no identity"This is gotten on the line
max_eig = lambdas.max()which makes meassume it emits a matrix with no real eigen values, not something we
can really control for.
Edit: Looking deeper, it would be good to know which solver is being used and if that would make a difference, it defaults to "auto"
Additionally, pytest seems to not be showing print statements which show the config which causes the issue, added the message to the error itself instead.