Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constants not handled good (and "swap"-logic) #93

Closed
shukon opened this issue Apr 9, 2020 · 0 comments · Fixed by #94
Closed

Constants not handled good (and "swap"-logic) #93

shukon opened this issue Apr 9, 2020 · 0 comments · Fixed by #94
Assignees

Comments

@shukon
Copy link
Collaborator

shukon commented Apr 9, 2020

  File "/home/shuki/Repos/fanova/fanova/visualizer.py", line 416, in create_most_important_pairwise_marginal_plots
    self.plot_pairwise_marginal((param1, param2), show=False, three_d=three_d, resolution=resolution)
  File "/home/shuki/Repos/fanova/fanova/visualizer.py", line 171, in plot_pairwise_marginal
    choices, zz = self.generate_pairwise_marginal(param_indices, resolution)
  File "/home/shuki/Repos/fanova/fanova/visualizer.py", line 121, in generate_pairwise_marginal
    swap = len(grid_fanova[1] > len(grid_fanova[0]))
TypeError: object of type 'numpy.int64' has no len()
  1. Constants cause a TypeError because their np.arrays in the grid-logic are np.squeeze()ed away, so they have no length and throw errors.
  2. While I'm not 100% sure what the swap in axes is supposed to do, there clearly is a logical mistake with the brackets here. Since it does not seem to have caused errors, it's unlikely to be critital, still should be fixed
@shukon shukon self-assigned this Apr 9, 2020
@shukon shukon closed this as completed in f92ae8e Apr 9, 2020
shukon added a commit that referenced this issue Apr 9, 2020
@shukon shukon reopened this Apr 9, 2020
shukon added a commit that referenced this issue Apr 11, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant