Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Metahyper and Its Test Cases #54

Closed
wants to merge 3 commits into from

Conversation

TarekAbouChakra
Copy link
Collaborator

The primary objective of this pull request is to address the issue related to Metahyper sampling an additional configuration.

Changes Made:

  • Modified the Metahyper code to ensure it is in a locked state during execution in multi-threading (previously the _check_max_evaluations function had code that was not in a locked state) to prevent potential race conditions.
  • Addressed instances where the internal read function in Metahyper was called twice by optimizing it to read only once to fulfill all purposes.
  • Cleared out ConfigInRun data after the completion of configuration evaluation and post hook execution.
  • Added sleep times for all locking operations when the lock is unavailable for stability.

Changes in Tests:

  • Adopted concurrent.futures as the multi-threading library in the tests, providing better control over processes for improved debugging and scalability when needed.

@eddiebergman
Copy link
Contributor

Heyo @TarekAbouChakra, I just merged #71 which reworked metagyper and converted it to neps.runtime. I'm going to look through these changes and turn it into a new clean PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants