Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a problem where display the room code was "??????" #363

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

tanakanira0118
Copy link
Contributor

@tanakanira0118 tanakanira0118 commented Oct 30, 2022

Overview

Fixed a problem that the room code could not be retrieved properly and displayed "??????" depending on the timing of returning to the lobby.

Fix

  • Add filtering by Regular Expression
    • Exact match to 4 or 6 letters of the alphabet
    • Exact match at ****** ※1

※1 If possible, I would like to correct the offset so that I can get the GameCode correctly even in StreamerMode, but I don't know which tool to use to check the Offset, so this is a stopgap measure.

Copy link
Collaborator

@kurokobo kurokobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works with/without streamer mode.
LGTM, thank you for your contribution!

@kurokobo kurokobo merged commit 08bbc1b into automuteus:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants