Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reproduces issue 947 #1191

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test: reproduces issue 947 #1191

wants to merge 2 commits into from

Conversation

autonomousapps
Copy link
Owner

@autonomousapps autonomousapps commented May 23, 2024

#947

This test currently fails, producing this erroneous advice:

> Task :buildHealth
Advice for :proj
Unused dependencies which should be removed:
  extraApi 'com.squareup.okio:okio:3.9.0'

DAGP is suggesting removing the dep on the "extra" source-set's dependency. The main source set depends on v3.8.0. This would lead to a compilation error.

Copy link

❌ Test workflow failed:

* Non-functional tests     : https://gradle.com/s/xxwftvdyvbdkm
* TestKit check            : https://gradle.com/s/2uedpqfcogar4
* JVM functional tests     : https://gradle.com/s/uzuc6q7jxo3gi
* Android functional tests : 
* Root buildHealth         : 
* TestKit buildHealth      : 

@jjohannes
Copy link
Collaborator

There was a .withSourceSet("extra") missing in the example setup. I am not sure if this reproduces (only) #947. There seems to be another issue with api vs implementation and multiple source sets.

Right now the test gives no advice, although it should give two. But this also happens if I use com.squareup.okio:okio:3.8.0 (same version) in both dependencies.

Copy link

❌ Test workflow failed:

* Non-functional tests     : https://gradle.com/s/kq4zdik42boug
* TestKit check            : https://gradle.com/s/kaehspxoz36a6
* JVM functional tests     : https://gradle.com/s/6kojtmbwmp7w2
* Android functional tests : 
* Root buildHealth         : 
* TestKit buildHealth      : 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants