chore: simplify KotlinCompile configuration #1343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So merge or close? |
|
I like simplifying things, but what I want before merging is some way to validate that the artifacts before and after the change are the same -- that they're built with the expected JVM target. |
Reason: the kotlin-gradle-plugin respects JvmToolchains
patrick-dedication
force-pushed
the
simplify-kotlin-compile-configuration
branch
from
09a71ee to
ccb8c9d
Compare
|
Do you an automated test? A thought that came to me a few days ago: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: the kotlin-gradle-plugin respects JvmToolchains, see here.
In case you wanted to be explicit about it, feel free to just close this PR :)