Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-net and Gemini-1b changes #55

Closed
wants to merge 19 commits into from
Closed

X-net and Gemini-1b changes #55

wants to merge 19 commits into from

Conversation

vedhavyas
Copy link
Contributor

@vedhavyas vedhavyas commented Jun 15, 2022

  • New X-net network

  • Gemini-1b changes
    - Reduce in and out peers to 500
    - Add extra nodes in singapore
    - Use latest release

  • Migrate from local backend to Terraform cloud backend

  • Set max socket connections

@vedhavyas vedhavyas changed the base branch from reduce_peers to main June 20, 2022 15:10
@vedhavyas vedhavyas changed the title X-net X-net and Gemini-1b changes Jun 20, 2022
@nazar-pc nazar-pc requested review from nazar-pc and a user June 20, 2022 15:50
@ghost ghost self-assigned this Jun 29, 2022
resources/common.tf Outdated Show resolved Hide resolved
resources/gemini-1b/backend.tf Outdated Show resolved Hide resolved
resources/gemini-1b/droplets.tf Outdated Show resolved Hide resolved
resources/gemini-1b/extra_nodes.tf Outdated Show resolved Hide resolved
resources/gemini-1b/utils/scripts/generate_node_keys.sh Outdated Show resolved Hide resolved
resources/gemini-1b/projects.tf Outdated Show resolved Hide resolved
Comment on lines 31 to 33
agent = false
# agent_identity = var.ssh_identity
private_key = var.alexey2_do_private_key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change here and below?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its used for tf cloud

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like a bit longer explanation than that. Why does it have to include your private key in variables?

@ghost ghost requested a review from nazar-pc July 22, 2022 10:02
@@ -55,9 +53,13 @@ data "digitalocean_ssh_key" "ved-key" {
name = "Ved SSH Key"
}

# Sensitive variable. Contains private key for connecting to concrete Digital Ocean droplets
variable "alexey2_do_private_key" { }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to add this private key here?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have done it for connecting cloud TF "null_resourse" to DO droplets.
Private key was saved in cloud TF secure/sensitive variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super clear on the architecture. Can you add more details to understand what you thinking ?

My initial thought process was that we want to use a cloud state so that these private/sensitive variables never leave our workspaces. The added benefit with this is that everyone can use their application keys and its much easier for auditing the changes made while the state is kept updated so anyone can pick up with out sharing state explicitly.

@@ -28,8 +28,8 @@ resource "null_resource" "setup_nodes" {
host = digitalocean_droplet.gemini-1b[count.index].ipv4_address
user = "root"
type = "ssh"
agent = true
agent_identity = var.ssh_identity
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you want to remove the identity?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found another way to connect cloud terraform "null_resource" to droplets.
In case if you know any ways to do it - please share.

@vedhavyas vedhavyas closed this Sep 7, 2022
@DaMandal0rian DaMandal0rian deleted the x-net branch September 19, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants