-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X-net and Gemini-1b changes #55
Conversation
resources/gemini-1b/provisioner.tf
Outdated
agent = false | ||
# agent_identity = var.ssh_identity | ||
private_key = var.alexey2_do_private_key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change here and below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its used for tf cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like a bit longer explanation than that. Why does it have to include your private key in variables?
@@ -55,9 +53,13 @@ data "digitalocean_ssh_key" "ved-key" { | |||
name = "Ved SSH Key" | |||
} | |||
|
|||
# Sensitive variable. Contains private key for connecting to concrete Digital Ocean droplets | |||
variable "alexey2_do_private_key" { } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to add this private key here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done it for connecting cloud TF "null_resourse" to DO droplets.
Private key was saved in cloud TF secure/sensitive variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super clear on the architecture. Can you add more details to understand what you thinking ?
My initial thought process was that we want to use a cloud state so that these private/sensitive variables never leave our workspaces. The added benefit with this is that everyone can use their application keys and its much easier for auditing the changes made while the state is kept updated so anyone can pick up with out sharing state explicitly.
@@ -28,8 +28,8 @@ resource "null_resource" "setup_nodes" { | |||
host = digitalocean_droplet.gemini-1b[count.index].ipv4_address | |||
user = "root" | |||
type = "ssh" | |||
agent = true | |||
agent_identity = var.ssh_identity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you want to remove the identity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found another way to connect cloud terraform "null_resource" to droplets.
In case if you know any ways to do it - please share.
New X-net network
Gemini-1b changes
- Reduce in and out peers to 500
- Add extra nodes in singapore
- Use latest release
Migrate from local backend to Terraform cloud backend
Set max socket connections