Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Tauri updater #276

Merged
merged 7 commits into from
Jul 5, 2022
Merged

Tauri updater #276

merged 7 commits into from
Jul 5, 2022

Conversation

isSerge
Copy link
Contributor

@isSerge isSerge commented Jul 4, 2022

  • adds updater to Tauri config
  • adds Tauri update keys to GitHub actions workflow

Currently, it will check for updates on the app launch. We still need to clarify UX for periodical checks and dropdown menu item for updates (check for update, install update, etc.)

@isSerge isSerge requested review from nazar-pc, a user and ozgunozerk July 4, 2022 08:45
@isSerge isSerge self-assigned this Jul 4, 2022
ghost
ghost previously approved these changes Jul 4, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok for demo

@ozgunozerk
Copy link
Contributor

We are going to abandon tauri actions in the future because it doesnt meet the requirements we have now.
I'm working on writing a new workflow and testing it, hopefully, it will finish soon.
What will happen to the updater then?

@nazar-pc
Copy link
Member

nazar-pc commented Jul 4, 2022

BTW, what are those requirements? Can we just submit a PR with additional capabilities to the official action or maintain a fork in the worst case?

@isSerge
Copy link
Contributor Author

isSerge commented Jul 4, 2022

@ozgunozerk it should work as long as we have gh actions workflow

@ozgunozerk
Copy link
Contributor

ozgunozerk commented Jul 4, 2022

Requirements are the following:

  • tauri actions only let us build the application for only one configuration (there are currently no way to provide both normal and opencl version for the same release)
  • tauri actions also do not let us rename the executables (we won't be able to rename them with opencl and with os_name)

When I contacted them, they suggested using a custom workflow instead of using tauri-actions.
We talked with Serge, and there may be lots of things to debug in tauri-actions. So, I went with re-writing our workflow without tauri-actions. It's here -> https://github.com/ozgunozerk/subspace-desktop-workflow/blob/main/.github/workflows/publish.yml

@ozgunozerk it should work as long as we have gh actions workflow

How to use these keys for updater without tauri-actions?

@isSerge
Copy link
Contributor Author

isSerge commented Jul 4, 2022

@ozgunozerk as far as I can see TAURI_PRIVATE_KEY and TAURI_KEY_PASSWORD are not used in the tauri-action itself. We just need to set these env variables when we create builds and bundles

@nazar-pc
Copy link
Member

nazar-pc commented Jul 4, 2022

@ozgunozerk as far as I can see TAURI_PRIVATE_KEY and TAURI_KEY_PASSWORD are not used in the tauri-action itself. We just need to set these env variables when we create builds and bundles

This doesn't make sense to me, why would we specify them if they are not used anyway?

@isSerge
Copy link
Contributor Author

isSerge commented Jul 4, 2022

@nazar-pc I meant they are used in the commands, which are called by tauri-action, so we still need them if we call those commands without tauri-action

@nazar-pc
Copy link
Member

nazar-pc commented Jul 4, 2022

Makes sense now 👍

@isSerge isSerge dismissed ghost ’s stale review via cb4878c July 4, 2022 11:03
nazar-pc
nazar-pc previously approved these changes Jul 4, 2022
@isSerge isSerge requested a review from a user July 5, 2022 05:37
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@isSerge isSerge merged commit 1b3e895 into main Jul 5, 2022
@isSerge isSerge deleted the tauri-updater branch July 5, 2022 08:15
i1i1 pushed a commit that referenced this pull request Jul 8, 2022
* add updater to tauri conf

* added updater to tauri config

* add tauri update keys

* update endpoint URL

* add env vars to ci-tests.yml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants