Skip to content

Commit

Permalink
Add TODO, enable test_cross_domains_messages_should_work
Browse files Browse the repository at this point in the history
Signed-off-by: linning <linningde25@gmail.com>
  • Loading branch information
NingLin-P committed Apr 18, 2024
1 parent bde4d7b commit 225830e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 2 additions & 0 deletions crates/pallet-subspace-mmr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ mod pallet {

impl<T: Config> OnNewRoot<T::MmrRootHash> for Pallet<T> {
fn on_new_root(root: &T::MmrRootHash) {
// TODO: this digest is not used remove it before next network reset but keep it
// as is for now to keep compatible with gemini-3h.
let digest = DigestItem::new_mmr_root(*root);
<frame_system::Pallet<T>>::deposit_log(digest);

Expand Down
3 changes: 0 additions & 3 deletions domains/client/domain-operator/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3344,10 +3344,7 @@ async fn existing_bundle_can_be_resubmitted_to_new_fork() {
assert_eq!(alice.client.info().best_number, pre_alice_best_number + 2);
}

// TODO: this test is flaky and may hang forever in CI, able it after the root cause is
// located and fixed.
#[tokio::test(flavor = "multi_thread")]
#[ignore]
async fn test_cross_domains_messages_should_work() {
let directory = TempDir::new().expect("Must be able to create temporary directory");

Expand Down

0 comments on commit 225830e

Please sign in to comment.