Pot verification preparation #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
force-pushed
the
pot-verification-preparation
branch
from
cfefdbe to
499639d
Compare
1 task
…imekeeper to derive seed and key properly between iterations
…e` and tune it slightly lower for local/devnet for better dev experience
nazar-pc
force-pushed
the
pot-verification-preparation
branch
from
499639d to
d819d2c
Compare
|
Rebased on |
…us log items instead for stateless verification purposes, prepare for future extension for entropy injection into seed too
nazar-pc
force-pushed
the
pot-verification-preparation
branch
from
d819d2c to
24d77ed
Compare
vedhavyas
reviewed
Aug 29, 2023
vedhavyas
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for PoT verification since a few consensus parameters were missing and information in the header wasn't sufficient.
For example we didn't have expected number of PoT iterations in consensus and corresponding number of iterations in the header to facilitate initial stateless PoT verification. I'm not excited that we have to add iterations into the header, but at the same time otherwise all PoT verification will be delayed to block import time.
PreDigestPotInfois an enum as well, currently it has just one variantRegularthat means no entropy injection and no adjustment of number of iterations happened yet. Once we have either of those, second enum variant will be added to handle those cases.Since we no longer need to be compatible with Gemini 3f I have done some breaking refactoring like making
PreDigestan enum to facilitate future protocol upgrades.I have set number of PoT iterations to what my machine can do for Gemini network and lower numbers such that it takes ~1s on other machines (roughly), workaround with sleep is removed and no longer necessary since PoT is doing actual work now.
There is still a lot of work left, but we're already cleaning up some TODOs.
Code contributor checklist: