Improve sync start speed on restart #1978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple important improvements here.
First of all, instead of starting with last finalized block it makes more sense to start with best block minus archiving confirmation depth. The reason for this is that finalized block is very deep due to paritytech/polkadot-sdk#1570 and we will end up downloading much more data and checking many more blocks than we actually need.
Second tweak is a fix for checking against last processed block rather than finalized block in actual block import that will make things both faster and remove unfortunate situation where last processed block number actually goes DOWN instead of up.
Both of these improvements greatly improve DSN sync, especially on restart (but also after temporary network outages).
Code contributor checklist: