Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Substrate fork version that reverts node sync fix #2138

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Oct 20, 2023

This imports autonomys/polkadot-sdk@892bf8e and corresponding autonomys/frontier#4 to revert paritytech/polkadot-sdk#1812 in order to not have #2122 until we know how to fix it.

There are a few potentially relevant upstream issues I'm now following:

Code contributor checklist:

Copy link
Contributor

@rahulksnv rahulksnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks.

I will let the upstream folks know the findings from last 2 days.

To be clear, the scenario that paritytech/polkadot-sdk#1812 addresses is still relevant, and nodes will get stuck if they get into that situation. But fixing that gets us into trouble with a different scenario (ongoing reorg in the network while the node is catching up: #2122). Guess the latter is more likely to happen, so reverting 1812 makes sense

@nazar-pc
Copy link
Member Author

Yes, the only reason to revert here is that new issue is happening more frequently. We definitely want to fix both.

@nazar-pc nazar-pc added this pull request to the merge queue Oct 20, 2023
Merged via the queue into main with commit a66e924 Oct 20, 2023
10 checks passed
@nazar-pc nazar-pc deleted the revert-sync-fix branch October 20, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants