Support shared hold id to have constant number of hold id #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we need to use withdraw_and_hold and then Currency::release Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
NOTE: we still need to keep track of the domain instantiation deposit in the state in case the DomainInstantiationDeposit change in the future Signed-off-by: linning <linningde25@gmail.com>
NOTE: we still need to keep track of the channel reserve fee in the state in case the ChannelReserveFee change in the future Signed-off-by: linning <linningde25@gmail.com>
Signed-off-by: linning <linningde25@gmail.com>
NingLin-P
force-pushed
the
shared-hold
branch
from
7a5bdff
to
338cf7b
Compare
teor2345
reviewed
Sep 11, 2024
dastansam
reviewed
Sep 13, 2024
|
@dariolina perhaps also @nazar-pc please take a look, thanks! |
nazar-pc
previously approved these changes
Sep 25, 2024
Signed-off-by: linning <linningde25@gmail.com>
nazar-pc
approved these changes
Sep 25, 2024
|
Had to stop CI due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2674
This PR supports shared hold id that is used in staking, domain instantiation, and XDM channel, such that we can have a constant number of hold id variants and extrinsic that require creating hold won't fail due to the fixed hold id limit.
Because we also support the nomination of multiple different operators, opening multiple channel, and instantiating multiple domains so we have to add storage keep tracking of the hold balance.
Code contributor checklist: