Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove object verification support #3038

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Conversation

nazar-pc
Copy link
Member

After discussion with @dariolina I confirmed that we do not plan to verify uploaded data in the runtime, which means we can simplify runtime API.

Code contributor checklist:

teor2345
teor2345 previously approved these changes Sep 19, 2024
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@nazar-pc nazar-pc added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@teor2345
Copy link
Contributor

Another test_bad_receipt_chain failure on macOS:
https://github.com/autonomys/subspace/actions/runs/10949497604/job/30402865143#step:12:1361

I restarted those tests.

@teor2345 teor2345 added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 20, 2024
…ation-support

# Conflicts:
#	test/subspace-test-runtime/src/lib.rs
@nazar-pc nazar-pc force-pushed the remove-object-verification-support branch from aded89f to 0ca493a Compare September 20, 2024 19:00
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nazar-pc nazar-pc added this pull request to the merge queue Sep 22, 2024
Merged via the queue into main with commit 97123d5 Sep 22, 2024
9 checks passed
@nazar-pc nazar-pc deleted the remove-object-verification-support branch September 22, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants