Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change snap-sync UX for early history. #3044

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

shamil-gadelshin
Copy link
Member

This PR adds a hard error for the attempt of snap-sync during the early history and makes the full snap sync mode default. Previously, snap sync attempts continued with errors: we don't have genesis state on snap sync and new blocks were unexpected because snap sync was skipped along with new state downloading.

Code contributor checklist:

@nazar-pc
Copy link
Member

I don't like this and don't think it is necessary. We need to fix it properly in Substrate and use --sync full in the meantime explicitly.

@teor2345
Copy link
Contributor

I think it would help users to set the default to full, so it works from genesis with the current code. But I agree that fixing it properly is the way to go.

@nazar-pc nazar-pc merged commit d92ef75 into main Sep 23, 2024
6 of 9 checks passed
@nazar-pc nazar-pc deleted the fix-messages-for-initial-snap-sync branch September 23, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants