-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JPG files don't recording in the data folder #996
Comments
Hi @Anton890304, are you also driving? Because you will only record images when you use throttle. Also, what do you mean by JupyterLab terminal? |
Hi @DocGarbanzo |
I have the same issue on a fresh Donkey install on Jetson Nano (not a fresh Ubuntu install). Same problem existed with PS4 controller, but this output is web controller. The only changes in
The "start recording" button in the web interface never changed (brief flash) when I clicked it: And when I clicked the button on the PS4 controller in an earlier attempt, this was the output:
Edit: I just remembered, my Python environment isn't strictly per the docs. I have Tensorflow 2.7.0 installed (because I couldn't install an old enough version on my M1 Mac), and when I was installing the packages in "Step 5: Setup Python Dependencies" I removed the version requirements because I was working on Oak-D-Lite support which had higher version requirements (IIRC, on Numpy). I probably won't be able to test a clean environment for at least a month (I'm going to Ireland to visit my parents!). |
@BrianHenryIE I installed Donkey Cart following the instructions https://github.com/autorope/donkeycar/blob/main/install/nano/install-jp44.sh Consequently. I have installed the recommended versions, but the Recording does not work. What do you think is the problem? |
The For the most part, I did follow docs.donkeycar.com. But, as I said above, I'm trying to add a new part with higher requirements so I did not follow them strictly. If I were you, I would follow docs.donkeycar.com instructions. It sounds like neither of use followed them properly, so it would be a good way to narrow down was it our own fault. Best yet, if we export our broken environment with:
Then once it is working we can figure what package difference caused the issue. |
It's possible it is a bug that got added with this pull request #985 That PR was to make the webui and the game controllers play nice together. There was a lot of state passed around that had to be synchonized; it's possible I messed up the recording state. |
I think the issue may be with that PR; line 258 of donkeycar/parts/web_controller/web.py; self.application.recording = data.get('recording', self.application.recording) should probably be
That value is not getting latched, and so it getting overwritten. @BrianHenryIE or @Anton890304 Please try making that change and see if it works for you. |
There is a duplicate of this issue here: #1005 |
@Ezward Thank you very much)))) |
- fix for #996 - version="4.3.10"
The fix is employed in this PR #1007 which is now merged. |
I found the issue in Donkey Car version 4.3.5 from the dev branch. Dataset writing doesn't work. JPG files don't recording in the data folder.
In the Donkey Car web interface, the (Start Recording [r]) button doesn't switch to recording mode. At that time in the JupyterLab terminal I see only:
INFO:donkeycar.parts.web_controller.web:{'recording': False}
When toggling recording on/off on the gamepad in the JupyterLab terminal, I see only:
recording: False
AUTO_RECORD_ON_THROTTLE = True
The text was updated successfully, but these errors were encountered: