Robothat auto record on throttle #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- port mode and recording latching code from joystick controller because auto-record on throttle was not working correctly with the robohat MM1.
- when throttle changes then latch the new recording state
- this was copied from joystick controller, but because robohat controller does not change mode, it is not needed.
|
I switched to the Yes, the It also did not record waypoints (records) when TCIII |
DocGarbanzo
approved these changes
Oct 23, 2022
| @@ -149,13 +155,21 @@ def run_threaded(self, img_arr=None, mode=None, recording=None): | |||
| """ | |||
| self.img_arr = img_arr | |||
|
|
|||
| # | |||
| # enforce defaults if they are not none. | |||
| # | |||
There was a problem hiding this comment.
Probably accidental duplication of comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue #1053
Robothat controller was not updated when we added code to make the game controllers and web controller cooperate. I ported the recording latching code to the robot hat controller.