1104 fix user angle in deep learning #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- that had been renamed user/steering in the PR that merged the computer vision template. - Much code in the deep learning pipeline explicitly hard-codes the literal `user/angle` so the deep learning code needs to continue to use that label. - This fix uses the Pipe() part to rename 'user/steering' to 'user/angle' immediately after it is emitted by the controller part.
- Pipe.py would output a bad tuple if only one argument was being passed throught. Now it explictly checks. - This caused complete.py to have invalid 'user/angle' values.
Closed
zlite
approved these changes
Feb 27, 2023
|
LGTM. Nice use of Pipe to copy between two namespaces |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a serious bug in complete.py when I renamed the steering output from
'user/angle'to'user/steering'. It turns out the the literal string 'user/angle' is used all over the place in the deep learning pipeline and DonkeyUI, so we can't change it.This fix the fixes complete.py so it uses 'user/angle' and 'pilot/angle'. This has been tested doing data collection, training and inference in autopilot mode.
The fix works by renaming the 'user/steering' value to 'user/angle' so both are in memory. I found and fixed a bug in the Pipe() part that happens when renaming a single argument; Python's variable argument facility outputs a tuple with two elements when only a single argument was passed; I now check for that and explicitly send back the single argument.