Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to passing full path to model in training #873

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

DocGarbanzo
Copy link
Contributor

@DocGarbanzo DocGarbanzo commented May 27, 2021

This got accidentally broken in 4.2 master.

  • Currently we have donkey train --tub data --model pilot.h5 which will create the model in the directory /model/pilot.h5.
  • Previously we had explicitly give path to the models directory: donkey train --tub data --model model/pilot.h5.

Here, we revert to the previous behaviour.

@DocGarbanzo DocGarbanzo requested review from tikurahul and sctse999 May 27, 2021 21:18
@DocGarbanzo
Copy link
Contributor Author

If this is merged, I will create a PR against master & do a patch release 4.2.1.

@zlite zlite merged commit a8ee2f8 into autorope:dev Jun 7, 2021
@DocGarbanzo DocGarbanzo deleted the revert_model_path_in_train branch June 13, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants