Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added fps counter part #897

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Added fps counter part #897

merged 1 commit into from
Nov 9, 2021

Conversation

JoeSiu
Copy link
Contributor

@JoeSiu JoeSiu commented Jul 13, 2021

An fps counter that shows the current fps while running, and shows the fps list when shutdown.

@JoeSiu JoeSiu mentioned this pull request Jul 13, 2021
Open
DocGarbanzo
DocGarbanzo requested changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@DocGarbanzo DocGarbanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at using a pep-8 compliant IDE so you can quickly see non-Pep-8 formatting issues.

donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/templates/cfg_complete.py Outdated Show resolved Hide resolved
@JoeSiu
Copy link
Contributor Author

JoeSiu commented Jul 21, 2021

I have reformated the code, sorry for the mistakes. Thank you!

DocGarbanzo
DocGarbanzo requested changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@DocGarbanzo DocGarbanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are only minor comments, looks good otherwise. Can you please rebase again and squash your commits into one - I will then merge it, the change is good.

donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
@JoeSiu
Copy link
Contributor Author

JoeSiu commented Sep 20, 2021

@DocGarbanzo I have rebased the commits, thanks!

DocGarbanzo
DocGarbanzo requested changes Sep 20, 2021
View reviewed changes
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/parts/fps.py Outdated Show resolved Hide resolved
donkeycar/templates/complete.py Show resolved Hide resolved
DocGarbanzo
DocGarbanzo approved these changes Nov 9, 2021
View reviewed changes
Copy link
Contributor

@DocGarbanzo DocGarbanzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good.

@DocGarbanzo DocGarbanzo merged commit 6ff5b2b into autorope:dev Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DocGarbanzo DocGarbanzo DocGarbanzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeSiu @DocGarbanzo