Skip to content

Commit

Permalink
Merge pull request Expensify#11682 from Expensify/Rory-CleanupChecklist
Browse files Browse the repository at this point in the history
  • Loading branch information
roryabraham authored Oct 8, 2022
2 parents 57d9fad + 1d76d57 commit 4a0be4d
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ This is a checklist for PR authors & reviewers. Please make sure to complete all
- [ ] If a new component is created I verified that:
- [ ] A similar component doesn't exist in the codebase
- [ ] All props are defined accurately and each prop has a `/** comment above it */`
- [ ] Any functional components have the `displayName` property
- [ ] The file is named correctly
- [ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- [ ] The only data being stored in the state is data necessary for rendering and nothing else
Expand Down Expand Up @@ -120,7 +119,6 @@ The reviewer will copy/paste it into a new comment and complete it after the aut
- [ ] If a new component is created I verified that:
- [ ] A similar component doesn't exist in the codebase
- [ ] All props are defined accurately and each prop has a `/** comment above it */`
- [ ] Any functional components have the `displayName` property
- [ ] The file is named correctly
- [ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- [ ] The only data being stored in the state is data necessary for rendering and nothing else
Expand Down

0 comments on commit 4a0be4d

Please sign in to comment.