fix: use request.routeOptions instead of deprecated request.routerPath #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HW13
approved these changes
Nov 3, 2023
|
Looks like type tests are failing, but that's not related to these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.routerPathwas deprecated in fastify@4.23.0. Since then it produces the following warning:request.routeOptionswas added in fastify@4.10.0. This approach supports backward compatibility while also avoiding accessingrequest.routerPathin case of a 404 in versions prior to 4.10.0.Prior to this change, the test suite emitted this warning 11 times. It is now emitted once, only for the new test which covers the case in which
request.routeOptionsdoes not exist.See also open-telemetry/opentelemetry-js-contrib#1757