Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snp_multi_vm: Add multi vms tests with different cpu and memory resou… #4231

Merged
merged 1 commit into from
Jan 9, 2025
Merged

snp_multi_vm: Add multi vms tests with different cpu and memory resou… #4231

merged 1 commit into from
Jan 9, 2025

Conversation

zixi-chen
Copy link
Contributor

@zixi-chen zixi-chen commented Dec 11, 2024 •
edited
Loading

id: 3207

@zixi-chen
Copy link
Contributor Author

@zhencliu @JinLiul @XueqiangWei Could you please help to review the patch?
(1/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: STARTED
(1/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: PASS (112.32 s)
(2/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: STARTED
(2/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: PASS (123.84 s)

@zixi-chen zixi-chen force-pushed the snp_multi_vms branch 3 times, most recently from 63c5ae1 to f354cef Compare December 11, 2024 06:32
@zhencliu
Copy link
Contributor

depends on #4224

@zixi-chen
Copy link
Contributor Author

Thanks @zhencliu, I updated this patch with 4224 comment, could you please review it？
(1/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: STARTED
(1/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: PASS (128.78 s)
(2/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: STARTED
(2/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: PASS (169.69 s)

zhencliu
zhencliu previously approved these changes Dec 19, 2024
View reviewed changes
@zixi-chen
Copy link
Contributor Author

@zhencliu Thanks for reviewing!
I updated the memory and vcpu resource assign rule, since when running test loop, mem may be defined in the profile and will be conflicted with this case. Could you please help to check it?
(1/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: STARTED
(1/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: PASS (219.68 s)
(2/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: STARTED
(2/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: PASS (362.91 s)

@zhencliu
Copy link
Contributor

@zhencliu Thanks for reviewing! I updated the memory and vcpu resource assign rule, since when running test loop, mem may be defined in the profile and will be conflicted with this case. Could you please help to check it? (1/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: STARTED (1/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: PASS (219.68 s) (2/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: STARTED (2/2) Host_RHEL.m9.u6.v0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.9..0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: PASS (362.91 s)

Hi Zixi, what's the difference? I didn't see you push a new commit today

@zixi-chen
Copy link
Contributor Author

Hi Zixi, what's the difference? I didn't see you push a new commit today

@zhencliu Pushed the latest change now.

@zhencliu
Copy link
Contributor

Hi Zixi, what's the difference? I didn't see you push a new commit today

@zhencliu Pushed the latest change now.

It looks fine from my side, the _fixed params are used for postfix_parse function in cartesian_config.py, it looks to me that these kinds of params' values will overwrite the others, not quite sure about that, but it could be OK if your tests passed

zhencliu
zhencliu previously approved these changes Dec 20, 2024
View reviewed changes
@JinLiul
Copy link
Contributor

JinLiul commented Dec 31, 2024

(1/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: STARTED
(1/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.snp_multi_vm.single_vcpu.q35: PASS (221.80 s)
(2/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: STARTED
(2/2) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.RHEL.10.0.x86_64.io-github-autotest-qemu.snp_multi_vm.four_vms.q35: PASS (392.24 s)
LGTM,thanks.

zhencliu
zhencliu previously approved these changes Jan 7, 2025
View reviewed changes
@XueqiangWei
Copy link
Contributor

@zixi-chen This case is only for linux, right? If yes, we'd better add "only Linux".

XueqiangWei
XueqiangWei reviewed Jan 7, 2025
View reviewed changes
qemu/tests/snp_multi_vm.py Outdated
1. Check host snp capability
2. Boot snp VM
3. Verify snp enabled in guest
4. Check snp qmp cmd and policy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the doc string, here should be snp multi vm related instead of snp basic config test. If I was wrong, please correct me. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XueqiangWei Updated.

@zixi-chen
snp_multi_vm: Add multi vms SNP tests
e334c23 
Boot multi vms with different cpu and memory resources

Signed-off-by: Zixi Chen <zixchen@redhat.com>
XueqiangWei
XueqiangWei approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@XueqiangWei XueqiangWei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Acked-by: xuwei@redhat.com

@XueqiangWei XueqiangWei merged commit bc41067 into autotest:master Jan 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XueqiangWei XueqiangWei XueqiangWei approved these changes

@zhencliu zhencliu zhencliu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zixi-chen @zhencliu @JinLiul @XueqiangWei