Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtio_fs_subtest_during_io: fix timeout issue #4243

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

xiagao
Copy link
Contributor

@xiagao xiagao commented Dec 24, 2024

The timeout variable name is fs_io_timeout but nog io_timeout in virtio_fs_utiles.py
ID: 3267

@xiagao
Copy link
Contributor Author

xiagao commented Dec 24, 2024

@hellohellenmao hi, could you help review this patch?

@xiagao
Copy link
Contributor Author

xiagao commented Dec 24, 2024

(1/1) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_fs_subtest_during_io.q35: STARTED
(1/1) Host_RHEL.m10.u0.ovmf.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.virtio_fs_subtest_during_io.q35: PASS (307.33 s)

@xiagao xiagao changed the title virtio_fs: resize the file size in windows vm virtio_fs_subtest_during_io: fix timeout issue Dec 24, 2024
Copy link
Contributor

@hellohellenmao hellohellenmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leidwang
Copy link
Contributor

Hi @xiagao Could you please check if someone else is needed to review this MR, thanks.

@xiagao
Copy link
Contributor Author

xiagao commented Jan 22, 2025

@YongxueHong Could you help review this patch, thanks.

@YongxueHong
Copy link
Contributor

Hi @xiagao
There is a typo for the commit message:
The timeout variable name is fs_io_timeout but nog io_timeout., nog -> not.
Thanks.

The timeout variable name is fs_io_timeout but not io_timeout.

Signed-off-by: Xiaoling Gao <xiagao@redhat.com>
@xiagao xiagao force-pushed the bz3267-viofs-size branch from cb07cf4 to 934fc16 Compare January 22, 2025 03:39
@xiagao
Copy link
Contributor Author

xiagao commented Jan 22, 2025

@YongxueHong The commit was updated, thanks.

Copy link
Contributor

@YongxueHong YongxueHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@YongxueHong YongxueHong merged commit 879c7d7 into autotest:master Jan 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants