Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphic settings camera list initialization #128

Conversation

mozhoku
Copy link
Collaborator

@mozhoku mozhoku commented Aug 12, 2024

Description

Fixes initialization of Graphic Settings panel in the UI.

Related links

Tests performed

Tested in the editor.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Alptuğ Cırıt <alptug@leodrive.ai>
@mozhoku mozhoku added the type:bug Software flaws or errors. label Aug 12, 2024
@mozhoku mozhoku self-assigned this Aug 12, 2024
@mozhoku mozhoku marked this pull request as ready for review August 12, 2024 11:22
@mozhoku mozhoku requested a review from Aysenayilmaz August 12, 2024 11:22
Copy link
Collaborator

@Aysenayilmaz Aysenayilmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it in the editor and the binary file, it works. Thanks for your work!

@Aysenayilmaz Aysenayilmaz merged commit 13f101c into autowarefoundation:main Aug 12, 2024
9 of 10 checks passed
@mozhoku mozhoku deleted the fix/graphic-settings-initialization branch August 13, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants