Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scene reloading #131

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

lchojnack
Copy link
Collaborator

Description

  • Add a description of the scene reloading.
    image
  • Fix Graphics Settings issue when reloading the scene

Related links

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@lchojnack lchojnack changed the title Fix/scene reloading fix: scene reloading Aug 19, 2024
Copy link
Collaborator

@mozhoku mozhoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. 🙏
I'll also make some changes in the GraphicsSettings.cs in this PR here:

@mozhoku mozhoku merged commit 6448886 into autowarefoundation:main Aug 19, 2024
6 of 7 checks passed
@lchojnack lchojnack self-assigned this Aug 20, 2024
@lchojnack lchojnack deleted the fix/scene-reloading branch December 9, 2024 07:46
@lchojnack lchojnack restored the fix/scene-reloading branch December 9, 2024 07:46
@lchojnack lchojnack deleted the fix/scene-reloading branch December 9, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants