fix: configuration refactor #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
xmfcx
approved these changes
Mar 28, 2024
|
I've tested it and i cant see any problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Description
This PR implements an easily accessible and convenient place to set all cross-manager configurations:
Assets/AWSIM/Scripts/Loader/SimConfiguration.cs.Minimal steps to add new param:
AWSIMConfiguration.csfileSimConfiguration.csLoader::LoadConfigFromGUI()An example param is also added: a "useShadow" switch for turning shadows on/off. See this exact commit for details, on how it is done in practice (check the c# files).
Finally, fixed the camera GUI not showing up when pressing "C".
Tests performed
Some manual runs.
Not applicable.
Effects on system behavior
Improves the readability of the code, and makes it easier to configure simulation and add new configuration options.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.