feat(perception_utils): add new package #1377

takayuki5168 · 2022-07-20T00:33:07Z

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

added perception_utils almost copied from the perception packages.

~~This PR depends on, and contains the following PR. So ignore these changes (boost_polygon_utils) in this PR.~~
#1367

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2022-07-20T00:45:57Z

Codecov Report

Merging #1377 (c1a1b14) into main (c834f05) will increase coverage by 0.14%.
The diff coverage is 56.70%.

@@            Coverage Diff            @@
##            main    #1377      +/-   ##
=========================================
+ Coverage   9.92%   10.06%   +0.14%     
=========================================
  Files       1117     1120       +3     
  Lines      77941    78139     +198     
  Branches   18087    18146      +59     
=========================================
+ Hits        7734     7865     +131     
- Misses     62677    62687      +10     
- Partials    7530     7587      +57

Flag	Coverage Δ		*Carryforward flag
differential	`56.70% <56.70%> (?)`
total	`9.81% <ø> (-0.10%)`	⬇️	Carriedforward from bc78b53

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
common/perception_utils/test/src/test_geometry.cpp	`50.87% <50.87%> (ø)`
...erception_utils/test/src/test_perception_utils.cpp	`53.75% <53.75%> (ø)`
common/perception_utils/src/perception_utils.cpp	`56.75% <56.75%> (ø)`
...tils/include/perception_utils/perception_utils.hpp	`88.23% <88.23%> (ø)`
...eption_utils/include/perception_utils/geometry.hpp	`100.00% <100.00%> (ø)`
...ils/test/src/geometry/test_boost_polygon_utils.cpp
...utoware_utils/src/geometry/boost_polygon_utils.cpp
...e/tier4_autoware_utils/geometry/boost_geometry.hpp	`100.00% <0.00%> (+50.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c834f05...c1a1b14. Read the comment docs.

takayuki5168 · 2022-07-20T11:40:52Z

@yukkysaito @miursh
Could you review this PR?
I've added the test.

This PR depends on, ~~and contains the following PR. So ignore these changes (boost_polygon_utils) in this PR.~~
#1367

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

takayuki5168 · 2022-07-21T05:07:09Z

(I'll change Tier IV typo (- > TIER IV) with another PR since a lot of files use Tier IV)

common/perception_utils/include/perception_utils/perception_utils.hpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

common/perception_utils/include/perception_utils/geometry.hpp

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

yukkysaito

LGTM

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

…verse into feat/perception-utils

* feat(perception_utils): add new package Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add test Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * add more functions Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix ci build error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update common/perception_utils/include/perception_utils/geometry.hpp Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> * fix ci error Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

…utowarefoundation#1377) feat(mrm_handler): operate mrm only when autonomous operation mode (autowarefoundation#7784) * feat: add isOperationModeAutonomous() function to MRM handler core The code changes add a new function `isOperationModeAutonomous()` to the MRM handler core. This function is used to check if the operation mode is set to autonomous. --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

takayuki5168 force-pushed the feat/perception-utils branch from 3bda692 to 4026e9b Compare July 20, 2022 11:36

takayuki5168 marked this pull request as ready for review July 20, 2022 11:36

takayuki5168 requested review from yukkysaito and miursh July 20, 2022 11:38

takayuki5168 added 3 commits July 20, 2022 23:06

feat(perception_utils): add new package

876d127

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

fix

1f58574

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

add test

6d66df5

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

takayuki5168 force-pushed the feat/perception-utils branch from 4026e9b to 6d66df5 Compare July 20, 2022 14:06

yukkysaito reviewed Jul 21, 2022

View reviewed changes

common/perception_utils/include/perception_utils/perception_utils.hpp Show resolved Hide resolved

add more functions

97b6883

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

yukkysaito self-requested a review July 21, 2022 12:43

yukkysaito reviewed Jul 21, 2022

View reviewed changes

common/perception_utils/include/perception_utils/geometry.hpp Outdated Show resolved Hide resolved

takayuki5168 and others added 2 commits July 21, 2022 23:14

fix ci build error

cc4f3e3

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Update common/perception_utils/include/perception_utils/geometry.hpp

bc78b53

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>

yukkysaito self-requested a review July 22, 2022 04:15

yukkysaito approved these changes Jul 22, 2022

View reviewed changes

takayuki5168 added 2 commits July 22, 2022 15:28

fix ci error

8bfd15b

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

Merge branch 'feat/perception-utils' of github.com:tier4/autoware.uni…

c1a1b14

…verse into feat/perception-utils

takayuki5168 merged commit 01ad83a into autowarefoundation:main Jul 25, 2022

takayuki5168 deleted the feat/perception-utils branch July 25, 2022 02:42

tier4-autoware-public-bot bot mentioned this pull request Jul 26, 2022

chore: sync upstream tier4/autoware.universe#88

Merged

tkimura4 mentioned this pull request Oct 7, 2022

feat(centerpoint): update ceterpoint tier4/autoware.universe#145

Merged

4 tasks

1222-takeshi mentioned this pull request Oct 7, 2022

feat(object_merger): refactor object merger tier4/autoware.universe#146

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(perception_utils): add new package #1377

feat(perception_utils): add new package #1377

takayuki5168 commented Jul 20, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading

takayuki5168 commented Jul 20, 2022 •

edited

Loading

takayuki5168 commented Jul 21, 2022

yukkysaito left a comment

feat(perception_utils): add new package #1377

feat(perception_utils): add new package #1377

Conversation

takayuki5168 commented Jul 20, 2022 • edited Loading

Description

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Jul 20, 2022 • edited Loading

Codecov Report

takayuki5168 commented Jul 20, 2022 • edited Loading

takayuki5168 commented Jul 21, 2022

yukkysaito left a comment

Choose a reason for hiding this comment

takayuki5168 commented Jul 20, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading

takayuki5168 commented Jul 20, 2022 •

edited

Loading