fix(ad_service_state_monitor): lock shread variables #1392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…conditions state_machine_ and state_input_ are shared by multiple callback groups (threads). So, mutex locks have been applied because it may cause race conditions. Signed-off-by: Yuuki Takano <yuuki.takano@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
state_machine_andstate_input_are shared by multiple callback groups (threads).So, mutex locks have been applied because it may cause race conditions.
Signed-off-by: Yuuki Takano yuuki.takano@tier4.jp
Description
AutowareStateMonitorNode::state_machine_andAutowareStateMonitorNode::state_input_are accessed by multiple threads without mutex locks. This may cause race conditions.So, mutex locks have been applied to the shared variables.
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.