Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): distance calculation for avoidance module #1510

Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Aug 3, 2022

Description

Before this PR, the distance status is not updated after registering the shift point.
I add the feature to calculate distance to registered shift point dynamically.

Furthermore, I fixed the problem that it outputs unnecessary log.

Related links

Tests performed

I tested in planning_simulator.

avoidance_rtc-2022-08-03_19.13.50.mp4

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

rej55 added 2 commits August 3, 2022 18:57
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 requested review from tkimura4 and taikitanaka3 August 3, 2022 10:22
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #1510 (e9e4773) into main (15f5b57) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1510      +/-   ##
==========================================
- Coverage   10.37%   10.31%   -0.07%     
==========================================
  Files        1135     1135              
  Lines       79579    80077     +498     
  Branches    18548    18910     +362     
==========================================
  Hits         8258     8258              
- Misses      63224    63678     +454     
- Partials     8097     8141      +44     
Flag Coverage Δ *Carryforward flag
differential 0.78% <0.00%> (?)
total 10.36% <0.00%> (ø) Carriedforward from 15f5b57

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/avoidance/avoidance_module.hpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
planning/behavior_path_planner/src/utilities.cpp 0.81% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f5b57...e9e4773. Read the comment docs.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2022-08-03-20-32-21.mp4

@tkimura4 tkimura4 merged commit ef4d7fa into autowarefoundation:main Aug 3, 2022
tkimura4 referenced this pull request in tier4/autoware.universe Aug 3, 2022
#1510)

* feat(behavior_path_planner): distance calculation for avoidance module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(behavior_path_planner): add initialization

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
tier4#1510)

* feat(behavior_path_planner): distance calculation for avoidance module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(behavior_path_planner): add initialization

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#1510)

* feat(behavior_path_planner): distance calculation for avoidance module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(behavior_path_planner): add initialization

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
tier4#1510)

* feat(behavior_path_planner): distance calculation for avoidance module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(behavior_path_planner): add initialization

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
autowarefoundation#1510)

* feat(behavior_path_planner): distance calculation for avoidance module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(behavior_path_planner): add initialization

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
tier4#1510)

* feat(behavior_path_planner): distance calculation for avoidance module

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* feat(behavior_path_planner): add initialization

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants