-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): distance calculation for avoidance module #1510
feat(behavior_path_planner): distance calculation for avoidance module #1510
Conversation
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1510 +/- ##
==========================================
- Coverage 10.37% 10.31% -0.07%
==========================================
Files 1135 1135
Lines 79579 80077 +498
Branches 18548 18910 +362
==========================================
Hits 8258 8258
- Misses 63224 63678 +454
- Partials 8097 8141 +44
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2022-08-03-20-32-21.mp4
#1510) * feat(behavior_path_planner): distance calculation for avoidance module Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(behavior_path_planner): add initialization Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
tier4#1510) * feat(behavior_path_planner): distance calculation for avoidance module Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(behavior_path_planner): add initialization Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
tier4#1510) * feat(behavior_path_planner): distance calculation for avoidance module Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(behavior_path_planner): add initialization Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
tier4#1510) * feat(behavior_path_planner): distance calculation for avoidance module Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(behavior_path_planner): add initialization Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
autowarefoundation#1510) * feat(behavior_path_planner): distance calculation for avoidance module Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(behavior_path_planner): add initialization Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
tier4#1510) * feat(behavior_path_planner): distance calculation for avoidance module Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * feat(behavior_path_planner): add initialization Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Description
Before this PR, the distance status is not updated after registering the shift point.
I add the feature to calculate distance to registered shift point dynamically.
Furthermore, I fixed the problem that it outputs unnecessary log.
Related links
Tests performed
I tested in planning_simulator.
avoidance_rtc-2022-08-03_19.13.50.mp4
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.