fix(behavior_path_planner): remove waitForData() in constructor

[TakaHoribe]

Description

Remove waitForData() in the constructor since it disturbs other nodes in the same component to launch.
Add isDataReady() instead at the beginning of the timer callback process.

Related links

Tests performed

• run psim and check if there is no degradation.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.
• The PR has been properly tested.
• The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.
• The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Merging #1684 (7516510) into main (7b94ead) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1684      +/-   ##
==========================================
- Coverage   10.72%   10.64%   -0.09%     
==========================================
  Files        1103     1103              
  Lines       78410    79037     +627     
  Branches    18649    19147     +498     
==========================================
+ Hits         8409     8410       +1     
- Misses      61087    61663     +576     
- Partials     8914     8964      +50     

Flag	Coverage Δ		*Carryforward flag
differential	0.79% <0.00%> (?)
total	10.70% <0.00%> (ø)		Carriedforward from 9dcce83

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp	0.34% <0.00%> (+0.11%)	⬆️
planning/behavior_path_planner/src/utilities.cpp	0.85% <0.00%> (-0.20%)	⬇️
...nning/behavior_path_planner/src/path_utilities.cpp	0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[tkimura4]

I confirmed that the behavior nodes were registered before a route was published by this PR.

[tkimura4]

LGTM

[taikitanaka3]

LGTM