Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity): use state machine util #1785

Merged

Conversation

taikitanaka3
Copy link
Contributor

Description

use state machine util in behavior velocity

  • blindspot
  • intersection
  • merge from private
  • no stopping area uses same state machine

Related links

Tests performed

by psim

Notes for reviewers

will be merged after #1773

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 changed the title Refactor/behavior velocity use state machine util refactor(behavior_velocity): use state machine util Sep 5, 2022
@taikitanaka3 taikitanaka3 marked this pull request as ready for review September 5, 2022 10:09
Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 enabled auto-merge (squash) September 6, 2022 01:52
@taikitanaka3 taikitanaka3 merged commit a4078bd into main Sep 6, 2022
@taikitanaka3 taikitanaka3 deleted the refactor/behavior_velocity_use_state_machine_util branch September 6, 2022 02:32
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* reafactor(behavior_velocity): unite state machine

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(blindspot): use state machine in util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(merge_from_private):  use state machine in utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: conflict change

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* reafactor(behavior_velocity): unite state machine

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(blindspot): use state machine in util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(merge_from_private):  use state machine in utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: conflict change

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* reafactor(behavior_velocity): unite state machine

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(blindspot): use state machine in util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(merge_from_private):  use state machine in utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: conflict change

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* reafactor(behavior_velocity): unite state machine

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(blindspot): use state machine in util

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* refactor(merge_from_private):  use state machine in utils

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: conflict change

Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka3 <ttatcoder@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants