-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_velocity_planner): negative time exception #1828
fix(behavior_velocity_planner): negative time exception #1828
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1828 +/- ##
==========================================
- Coverage 10.45% 10.39% -0.07%
==========================================
Files 1220 1221 +1
Lines 87626 88285 +659
Branches 20523 21038 +515
==========================================
+ Hits 9165 9179 +14
- Misses 68989 69592 +603
- Partials 9472 9514 +42
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
but this may conflict with this PR please fix PR #1213
…dation#1828) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…dation#1828) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…dation#1828) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…dation#1828) Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com> Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
The current implementation in
behavior_velocity_planner
causes an exception as below. THis PR fixes the bug.Related links
Tests performed
Run planning simulator.
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.