Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_planner): negative time exception #1828

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Sep 9, 2022

Description

The current implementation in behavior_velocity_planner causes an exception as below. THis PR fixes the bug.

[component_container_mt-47] terminate called after throwing an instance of 'std::runtime_error'
[component_container_mt-47]   what():  cannot store a negative time point in rclcpp::Time

Related links

Tests performed

Run planning simulator.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1828 (4ebddb4) into main (edfe616) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1828      +/-   ##
==========================================
- Coverage   10.45%   10.39%   -0.07%     
==========================================
  Files        1220     1221       +1     
  Lines       87626    88285     +659     
  Branches    20523    21038     +515     
==========================================
+ Hits         9165     9179      +14     
- Misses      68989    69592     +603     
- Partials     9472     9514      +42     
Flag Coverage Δ *Carryforward flag
differential 4.28% <0.00%> (?)
total 10.44% <0.00%> (ø) Carriedforward from edfe616

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...include/behavior_velocity_planner/planner_data.hpp 0.00% <0.00%> (ø)
planning/behavior_velocity_planner/src/node.cpp 0.70% <0.00%> (+0.28%) ⬆️
...city_planner/src/scene_module/blind_spot/debug.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...ty_planner/src/scene_module/intersection/debug.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/detection_area/debug.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/intersection/manager.cpp 0.00% <0.00%> (ø)
..._planner/src/scene_module/occlusion_spot/debug.cpp 0.00% <0.00%> (ø)
...lanner/src/scene_module/no_stopping_area/debug.cpp 0.00% <0.00%> (ø)
...nner/include/utilization/boost_geometry_helper.hpp 0.00% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but this may conflict with this PR please fix PR #1213

@taikitanaka3 taikitanaka3 merged commit 6b024cb into autowarefoundation:main Sep 12, 2022
@taikitanaka3 taikitanaka3 deleted the fix/behavior-velocity-negative-time-exception branch September 12, 2022 05:16
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…dation#1828)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…dation#1828)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…dation#1828)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…dation#1828)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants