-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): guard invalid shift point #1924
fix(avoidance): guard invalid shift point #1924
Conversation
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Codecov ReportBase: 10.32% // Head: 10.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
==========================================
+ Coverage 10.32% 10.37% +0.04%
==========================================
Files 1147 1141 -6
Lines 81613 75351 -6262
Branches 19049 18796 -253
==========================================
- Hits 8428 7815 -613
+ Misses 64062 58632 -5430
+ Partials 9123 8904 -219
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…135) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…134) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…utowarefoundation#135) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
…utowarefoundation#135) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Signed-off-by: satoshi-ota satoshi.ota928@gmail.com
Description
guard shift points whose start point exists behind the ego position
before (chattering the avoidance path)
simplescreenrecorder-2022-09-21_18.15.55.mp4
simplescreenrecorder-2022-09-21_18.25.00.mp4
Link (For TIER4 INTERNAL)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.