Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): guard invalid shift point #1924

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Sep 21, 2022

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

  • guard shift points whose start point exists behind the ego position

  • before (chattering the avoidance path)

simplescreenrecorder-2022-09-21_18.15.55.mp4
  • after (the avoidance path is stable)
simplescreenrecorder-2022-09-21_18.25.00.mp4

Link (For TIER4 INTERNAL)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 10.32% // Head: 10.37% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (816fe12) compared to base (521f777).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1924      +/-   ##
==========================================
+ Coverage   10.32%   10.37%   +0.04%     
==========================================
  Files        1147     1141       -6     
  Lines       81613    75351    -6262     
  Branches    19049    18796     -253     
==========================================
- Hits         8428     7815     -613     
+ Misses      64062    58632    -5430     
+ Partials     9123     8904     -219     
Flag Coverage Δ *Carryforward flag
differential 1.27% <0.00%> (?)
total 10.42% <ø> (+0.11%) ⬆️ Carriedforward from 521f777

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
system/default_ad_api/src/interface.cpp 0.00% <0.00%> (-71.43%) ⬇️
...ng_simulator/vehicle_model/sim_model_interface.hpp 0.00% <0.00%> (-66.67%) ⬇️
system/default_ad_api/src/localization.cpp 0.00% <0.00%> (-42.86%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
system/default_ad_api/src/routing.cpp 0.00% <0.00%> (-33.34%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
...wer/include/trajectory_follower/lowpass_filter.hpp 50.00% <0.00%> (-25.00%) ⬇️
...odel/vehicle_model_bicycle_kinematics_no_delay.cpp 70.00% <0.00%> (-21.31%) ⬇️
...mon/autoware_point_types/test/test_point_types.cpp 66.66% <0.00%> (-16.67%) ⬇️
... and 708 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) September 21, 2022 09:37
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 68f0f7d into autowarefoundation:main Sep 21, 2022
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 21, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Sep 21, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Sep 21, 2022
…135)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Sep 21, 2022
…134)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
@satoshi-ota satoshi-ota deleted the fix/guard-invalid-shift-point branch September 21, 2022 22:52
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 7, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Oct 28, 2022
…utowarefoundation#135)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
satoshi-ota added a commit to satoshi-ota/autoware.universe that referenced this pull request Jan 16, 2023
…utowarefoundation#135)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants