feat: add rtc manager rviz plugin #1936

taikitanaka3 · 2022-09-22T09:27:01Z

Signed-off-by: tanaka3 ttatcoder@outlook.jp

Description

add rtc rviz plugin

TODO in another PR

make rtc rosbag debugger
approve button for oncoming rtc status

Tests performed

By Psim
this PR needs up to this commit
tier4/tier4_autoware_msgs@8b85e6e
so v0.32.0 xx1 old version is not compatible right now.

Notes for reviewers

add new panel ->

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

The PR follows the pull request guidelines.
The PR has been properly tested.
The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

There are no open discussions or they are tracked via tickets.
The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

codecov · 2022-09-22T09:40:06Z

Codecov Report

Base: 10.27% // Head: 10.25% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (fbf410b) compared to base (88f1dfd).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   10.27%   10.25%   -0.03%     
==========================================
  Files        1154     1156       +2     
  Lines       82071    82240     +169     
  Branches    19102    19102              
==========================================
  Hits         8436     8436              
- Misses      64492    64661     +169     
  Partials     9143     9143

Flag	Coverage Δ		*Carryforward flag
differential	`0.00% <0.00%> (?)`
total	`10.26% <ø> (ø)`		Carriedforward from 25fa82f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp	`0.00% <0.00%> (ø)`
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.hpp	`0.00% <0.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

rej55

Thank you for your contribution.
I wrote some comments. Could you check them?

common/rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp

shmpwk · 2022-09-27T07:00:43Z

@taikitanaka3
Can auto mode and manual mode get only one side? not both state.
Screencast from 2022年09月27日 15時56分59秒.webm

taikitanaka3 · 2022-09-27T07:24:38Z

@shmpwk
OK I fixed

shmpwk · 2022-09-27T07:33:16Z

@taikitanaka3
Is this behavior expected? Maybe not this plugin problem but the lane change problem?
Screencast from 2022年09月27日 16時31分20秒.webm

taikitanaka3 · 2022-09-27T07:35:49Z

@shmpwk
this is not related to rtc this is lanechange module behavior and as expected for current implemenation

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

mitsudome-r · 2022-09-27T08:26:32Z

Could you update Readme so that people other than TIER IV can use this tool as well?

common/rtc_manager_rviz_plugin/README.md

shmpwk · 2022-09-27T09:51:20Z

This behavior I mentioned #1936 (comment) was improved with the latest Autoware, so there seems no problem 🙇
Screencast from 2022年09月27日 18時48分39秒.webm

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

taikitanaka3 · 2022-09-29T02:31:19Z

@mitsudome-r
OK but this panel is still developing , when everything is merged I will make documents

rej55

LGTM

* feat: add rtc manager rviz plugin Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: cosmetic change Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: remove indent Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: add rtc safe unsafe color Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: simplify layout Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: update rtc panel Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat: add rtc manager rviz plugin (autowarefoundation#1936) * feat: add rtc manager rviz plugin Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: cosmetic change Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: remove indent Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: add rtc safe unsafe color Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: simplify layout Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: update rtc panel Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat(rtc_manager_rviz_plugin): down grade to v0.5.2 Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat: add rtc manager rviz plugin Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: cosmetic change Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: remove indent Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: add rtc safe unsafe color Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: simplify layout Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: update rtc panel Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

…oundation#144) * feat: add rtc manager rviz plugin (autowarefoundation#1936) * feat: add rtc manager rviz plugin Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: cosmetic change Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: remove indent Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: add rtc safe unsafe color Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: simplify layout Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat: update rtc panel Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat(rtc_manager_rviz_plugin): down grade to v0.5.2 Signed-off-by: tanaka3 <ttatcoder@outlook.jp> Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

taikitanaka3 mentioned this pull request Sep 22, 2022

information inside rtc is complicated but not visualized #1937

Closed

3 tasks

taikitanaka3 requested review from shmpwk, rej55, isamu-takagi and tkimura4 September 22, 2022 09:31

taikitanaka3 marked this pull request as ready for review September 22, 2022 09:44

rej55 reviewed Sep 26, 2022

View reviewed changes

common/rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp Outdated Show resolved Hide resolved

common/rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp Outdated Show resolved Hide resolved

common/rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp Show resolved Hide resolved

isamu-takagi reviewed Sep 26, 2022

View reviewed changes

common/rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp Outdated Show resolved Hide resolved

common/rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp Show resolved Hide resolved

taikitanaka3 enabled auto-merge (squash) September 27, 2022 03:09

taikitanaka3 added 8 commits September 27, 2022 17:14

feat: add rtc manager rviz plugin

8ff1d39

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

chore: cosmetic change

10ac0ae

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

chore: remove indent

4d17dc3

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

feat: add rtc safe unsafe color

e55b6a4

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

fix: typo

c02e3f9

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

chore: simplify layout

c009058

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

feat: update rtc panel

a065c80

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

feat::update ui

25fa82f

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

shmpwk force-pushed the feat/add_rtc_manager_rviz_plugin branch from f24bce5 to 25fa82f Compare September 27, 2022 08:14

mitsudome-r self-requested a review September 27, 2022 08:25

rej55 reviewed Sep 27, 2022

View reviewed changes

common/rtc_manager_rviz_plugin/README.md Outdated Show resolved Hide resolved

doc: update

fbf410b

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

rej55 approved these changes Sep 29, 2022

View reviewed changes

taikitanaka3 merged commit c6e0554 into autowarefoundation:main Sep 29, 2022

taikitanaka3 deleted the feat/add_rtc_manager_rviz_plugin branch September 29, 2022 02:55

tier4-autoware-public-bot bot mentioned this pull request Sep 30, 2022

chore: sync upstream tier4/autoware.universe#140

Merged

taikitanaka3 mentioned this pull request Oct 6, 2022

feat(rtc_manager_rviz_plugin): add rtc manager viewer only tier4/autoware.universe#144

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add rtc manager rviz plugin #1936

feat: add rtc manager rviz plugin #1936

taikitanaka3 commented Sep 22, 2022 •

edited

Loading

codecov bot commented Sep 22, 2022 •

edited

Loading

rej55 left a comment

shmpwk commented Sep 27, 2022

taikitanaka3 commented Sep 27, 2022

shmpwk commented Sep 27, 2022 •

edited

Loading

taikitanaka3 commented Sep 27, 2022

mitsudome-r commented Sep 27, 2022

shmpwk commented Sep 27, 2022

taikitanaka3 commented Sep 29, 2022

rej55 left a comment

feat: add rtc manager rviz plugin #1936

feat: add rtc manager rviz plugin #1936

Conversation

taikitanaka3 commented Sep 22, 2022 • edited Loading

Description

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

Post-review checklist for the PR author

codecov bot commented Sep 22, 2022 • edited Loading

Codecov Report

rej55 left a comment

Choose a reason for hiding this comment

shmpwk commented Sep 27, 2022

taikitanaka3 commented Sep 27, 2022

shmpwk commented Sep 27, 2022 • edited Loading

taikitanaka3 commented Sep 27, 2022

mitsudome-r commented Sep 27, 2022

shmpwk commented Sep 27, 2022

taikitanaka3 commented Sep 29, 2022

rej55 left a comment

Choose a reason for hiding this comment

taikitanaka3 commented Sep 22, 2022 •

edited

Loading

codecov bot commented Sep 22, 2022 •

edited

Loading

shmpwk commented Sep 27, 2022 •

edited

Loading