Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raw-vehicle-cmd-converter): add test for pid #2212

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

tohmae
Copy link
Contributor

@tohmae tohmae commented Nov 3, 2022

Description

Issue: #2082
I add unit test for pid.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for PR

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Base: 11.09% // Head: 11.17% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (404411e) compared to base (333044b).
Patch coverage: 34.04% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
+ Coverage   11.09%   11.17%   +0.08%     
==========================================
  Files        1202     1202              
  Lines       86170    86250      +80     
  Branches    20680    20745      +65     
==========================================
+ Hits         9559     9638      +79     
+ Misses      66661    66611      -50     
- Partials     9950    10001      +51     
Flag Coverage Δ *Carryforward flag
differential 11.09% <30.76%> (?)
total 11.06% <36.36%> (ø) Carriedforward from 333044b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._converter/test/test_raw_vehicle_cmd_converter.cpp 38.06% <34.04%> (+6.06%) ⬆️
...onverter/include/raw_vehicle_cmd_converter/pid.hpp 66.66% <0.00%> (+66.66%) ⬆️
vehicle/raw_vehicle_cmd_converter/src/pid.cpp 85.71% <0.00%> (+85.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taikitanaka3 taikitanaka3 merged commit 7c9f6e2 into autowarefoundation:main Nov 7, 2022
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…#2212)

* add-vehicle-pid-test

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
…#2212)

* add-vehicle-pid-test

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants