-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ndt_scan_matcher): modularize callback_sensor_points and some related functions #2224
refactor(ndt_scan_matcher): modularize callback_sensor_points and some related functions #2224
Conversation
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Codecov ReportBase: 11.09% // Head: 11.05% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2224 +/- ##
==========================================
- Coverage 11.09% 11.05% -0.05%
==========================================
Files 1201 1203 +2
Lines 86193 86530 +337
Branches 20704 20706 +2
==========================================
Hits 9564 9564
- Misses 66670 66874 +204
- Partials 9959 10092 +133
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Close this PR as this is not necessary for now. |
Description
Aiming at integrating dynamic map loading feature in
ndt_scan_matcher
smoothly, I would like to modularize ndt_scan_matcher into the following modules:As a third step, I would like to modularize callback_sensor_points and some related functions as an individual module.
Previous PRs:
Some concerns:
ndt_ptr_ptr_
the best practice to share thendt_ptr_
among several objects?(A side note: this would be the largest PR in terms of the modified lines by far until the dynamic map loading integration 🔥 )
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.