-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(raw_vehicle_cmd_converter): fix unnecessary row check #2446
fix(raw_vehicle_cmd_converter): fix unnecessary row check #2446
Conversation
Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 11.32% // Head: 11.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2446 +/- ##
==========================================
+ Coverage 11.32% 11.34% +0.02%
==========================================
Files 1166 1166
Lines 81768 81778 +10
Branches 20880 20886 +6
==========================================
+ Hits 9260 9278 +18
+ Misses 62639 62633 -6
+ Partials 9869 9867 -2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…undation#2446) * fix(raw_vehicle_cmd_converter): fix unnecessary row check Signed-off-by: taikitanaka <ttatcoder@outlook.jp> * ci(pre-commit): autofix * chore: update Signed-off-by: taikitanaka <ttatcoder@outlook.jp> Signed-off-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…undation#2446) * fix(raw_vehicle_cmd_converter): fix unnecessary row check Signed-off-by: taikitanaka <ttatcoder@outlook.jp> * ci(pre-commit): autofix * chore: update Signed-off-by: taikitanaka <ttatcoder@outlook.jp> Signed-off-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…undation#2446) * fix(raw_vehicle_cmd_converter): fix unnecessary row check Signed-off-by: taikitanaka <ttatcoder@outlook.jp> * ci(pre-commit): autofix * chore: update Signed-off-by: taikitanaka <ttatcoder@outlook.jp> Signed-off-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…undation#2446) * fix(raw_vehicle_cmd_converter): fix unnecessary row check Signed-off-by: taikitanaka <ttatcoder@outlook.jp> * ci(pre-commit): autofix * chore: update Signed-off-by: taikitanaka <ttatcoder@outlook.jp> Signed-off-by: taikitanaka <ttatcoder@outlook.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: taikitanaka ttatcoder@outlook.jp
Description
This PR fix run time error but validation of row was not necessary so I skip check it.
#2152
test with unit test
replace accel map with data/accel_map.csv
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.