Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(raw_vehicle_cmd_converter): fix unnecessary row check #2446

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Dec 5, 2022

Signed-off-by: taikitanaka ttatcoder@outlook.jp

Description

This PR fix run time error but validation of row was not necessary so I skip check it.
#2152

test with unit test

colcon test --packages-select "$PKG" --event-handlers console_direct+

replace accel map with data/accel_map.csv

ps1,0,0.69,1.39,2.08,2.78,3.47,4.17,4.86,5.56,6.25
0,-0.1029223266,-0.1061158307,-0.109164218,-0.1191284783,-0.1261155829,-0.1307586564,-0.1340428698,-0.1378086633,-0.143831744,-0.1525
0.1,-0.06609631546,-0.0688925451,-0.0734351234,-0.07783215714,-0.08062835425,-0.08414421277,-0.0925801766,-0.1074968219,-0.1213093058,-0.1295088755
0.2,0.02044874577,0.0128197972,0.008220379945,0.005174855935,-0.0004104642949,-0.007597981529,-0.01383377857,-0.01811042919,-0.03260093622,-0.04714348618
0.3,0.1461922622,0.1400437435,0.1360867209,0.1337902876,0.1269005786,0.1204052624,0.1184190313,0.1109230093,0.09270970761,0.07762720052
0.4,0.3873699212,0.3732465653,0.3669712517,0.3538140707,0.3414876737,0.3341254862,0.3245454926,0.2911986578,0.2581954178,0.225
0.5,0.6749221864,0.6300341855,0.6117559539,0.5985938883,0.5868190156,0.5714869678,0.5432264689,0.4524596046,0.3840638324,0.345
0.6,0.95,0.91,0.885,0.87,0.84,0.795,0.7586778306,0.5806075399,0.52,0.48
0.7,1.25,1.283,1.25,1.23,1.205,1.1,0.921480622,0.7872996694,0.6132585148,0.525
0.8,1.65,1.61,1.565,1.529153118,1.471847619,1.400142346,1.187456207,0.875,0.7,0.575
0.9,2,1.92,1.825,1.72,1.625,1.533770897,1.278954634,0.972463712,0.7831982841,0.65
1,2.2,2.1,2,1.85,1.7,1.618929595,1.392878796,1.09,0.9035345146,0.785

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 requested review from TakaHoribe and a team as code owners December 5, 2022 07:15
@taikitanaka3 taikitanaka3 requested a review from mkuri December 5, 2022 07:16
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Dec 5, 2022
pre-commit-ci bot and others added 2 commits December 5, 2022 07:17
Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 enabled auto-merge (squash) December 5, 2022 07:34
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 11.32% // Head: 11.34% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (7766574) compared to base (ae49c3f).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2446      +/-   ##
==========================================
+ Coverage   11.32%   11.34%   +0.02%     
==========================================
  Files        1166     1166              
  Lines       81768    81778      +10     
  Branches    20880    20886       +6     
==========================================
+ Hits         9260     9278      +18     
+ Misses      62639    62633       -6     
+ Partials     9869     9867       -2     
Flag Coverage Δ *Carryforward flag
differential 10.89% <25.00%> (?)
total 11.32% <25.00%> (+<0.01%) ⬆️ Carriedforward from 30fed2c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...r/include/raw_vehicle_cmd_converter/csv_loader.hpp 100.00% <ø> (ø)
...ehicle/raw_vehicle_cmd_converter/src/accel_map.cpp 33.33% <0.00%> (ø)
...ehicle/raw_vehicle_cmd_converter/src/brake_map.cpp 40.00% <0.00%> (ø)
...ehicle/raw_vehicle_cmd_converter/src/steer_map.cpp 35.29% <0.00%> (ø)
...hicle/raw_vehicle_cmd_converter/src/csv_loader.cpp 72.22% <100.00%> (+7.93%) ⬆️
...planning_evaluator/src/planning_evaluator_node.cpp 34.37% <0.00%> (-2.09%) ⬇️
...nning_simulator/simple_planning_simulator_core.hpp 77.77% <0.00%> (ø)
...nning_simulator/simple_planning_simulator_core.cpp 38.10% <0.00%> (+0.68%) ⬆️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 67.85% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@taikitanaka3 taikitanaka3 merged commit 2a086eb into autowarefoundation:main Dec 5, 2022
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Dec 7, 2022
…undation#2446)

* fix(raw_vehicle_cmd_converter): fix unnecessary row check

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

* chore: update

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Dec 9, 2022
…undation#2446)

* fix(raw_vehicle_cmd_converter): fix unnecessary row check

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

* chore: update

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…undation#2446)

* fix(raw_vehicle_cmd_converter): fix unnecessary row check

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

* chore: update

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…undation#2446)

* fix(raw_vehicle_cmd_converter): fix unnecessary row check

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

* chore: update

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>

Signed-off-by: taikitanaka <ttatcoder@outlook.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@taikitanaka3 taikitanaka3 deleted the fix/raw_vehicle_cmd_converter_row_check branch January 9, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants