Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trajectory_visualizer): fix topic callback #2496

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Dec 13, 2022

Description

Temporally fix. Without this code, subscriber won't work due to the callback being stuck.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 13, 2022
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 10.56% // Head: 10.56% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (261aaac) compared to base (3a24859).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
- Coverage   10.56%   10.56%   -0.01%     
==========================================
  Files        1264     1264              
  Lines       87335    87260      -75     
  Branches    20936    20936              
==========================================
- Hits         9230     9222       -8     
+ Misses      68222    68157      -65     
+ Partials     9883     9881       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.56% <ø> (-0.01%) ⬇️ Carriedforward from f1a9a96

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 60.71% <0.00%> (-14.29%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...n_planner/src/lanelet2_plugins/default_planner.cpp 0.00% <0.00%> (ø)
...planner/src/lanelet2_plugins/utility_functions.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe closed this Dec 19, 2022
@TakaHoribe TakaHoribe reopened this Feb 14, 2023
@TakaHoribe TakaHoribe marked this pull request as ready for review February 14, 2023 12:03
@TakaHoribe TakaHoribe requested review from taikitanaka3 and a team as code owners February 14, 2023 12:03
@TakaHoribe TakaHoribe requested a review from kosuke55 February 14, 2023 12:03
@TakaHoribe TakaHoribe merged commit 7a04b75 into autowarefoundation:main Feb 15, 2023
@TakaHoribe TakaHoribe deleted the fix-trajectory-visualizer branch February 15, 2023 04:33
kosuke55 pushed a commit to tier4/autoware.universe that referenced this pull request Feb 16, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants