-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trajectory_visualizer): fix topic callback #2496
fix(trajectory_visualizer): fix topic callback #2496
Conversation
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Codecov ReportBase: 10.56% // Head: 10.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2496 +/- ##
==========================================
- Coverage 10.56% 10.56% -0.01%
==========================================
Files 1264 1264
Lines 87335 87260 -75
Branches 20936 20936
==========================================
- Hits 9230 9222 -8
+ Misses 68222 68157 -65
+ Partials 9883 9881 -2
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Description
Temporally fix. Without this code, subscriber won't work due to the callback being stuck.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.