Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): enable generating backward drivable area #2512

Merged

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Dec 16, 2022

Signed-off-by: yutaka purewater0901@gmail.com

Description

Enable generating backward drivable area by adding a flag.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 10.54% // Head: 10.42% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (faf3048) compared to base (418d8e5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2512      +/-   ##
==========================================
- Coverage   10.54%   10.42%   -0.12%     
==========================================
  Files        1266     1265       -1     
  Lines       87648    88698    +1050     
  Branches    20937    21796     +859     
==========================================
+ Hits         9242     9248       +6     
- Misses      68543    69481     +938     
- Partials     9863     9969     +106     
Flag Coverage Δ *Carryforward flag
differential 3.15% <0.00%> (?)
total 10.56% <0.00%> (+0.02%) ⬆️ Carriedforward from 70d3978

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...based_prediction/src/map_based_prediction_node.cpp 0.00% <0.00%> (ø)
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...de/behavior_path_planner/behavior_tree_manager.hpp 0.00% <0.00%> (ø)
...th_planner/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 29.41% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.27% <0.00%> (+0.08%) ⬆️
...ehavior_path_planner/src/behavior_tree_manager.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55
Copy link
Contributor

the default value of is_driving_forward is true, so it does not affect existing code.

@purewater0901 purewater0901 merged commit f67d733 into autowarefoundation:main Dec 20, 2022
@purewater0901 purewater0901 deleted the feat/enable-backward-drivable-area branch December 20, 2022 02:25
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…autowarefoundation#2512)

Signed-off-by: yutaka <purewater0901@gmail.com>

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants