Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): error messsage when no pull over/out planners #2644

Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jan 12, 2023

Description

print error message when no pull over/out planner like

enable_shift_pull_out: false
enable_geometric_pull_out: false

or

enable_shift_parking: false
enable_arc_forward_parking: false
enable_arc_backward_parking: false

Related links

Tests performed

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 12.18% // Head: 12.14% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (3b728ae) compared to base (7d027ba).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2644      +/-   ##
==========================================
- Coverage   12.18%   12.14%   -0.04%     
==========================================
  Files        1177     1177              
  Lines       83404    83649     +245     
  Branches    23595    23774     +179     
==========================================
  Hits        10160    10160              
- Misses      62473    62709     +236     
- Partials    10771    10780       +9     
Flag Coverage Δ *Carryforward flag
differential 4.97% <0.00%> (?)
total 12.18% <0.00%> (ø) Carriedforward from 7d027ba

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

…nner

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/pull_over_out_no_planner_error branch from 76d273d to 3b728ae Compare January 12, 2023 13:42
@kosuke55 kosuke55 merged commit a1dfc11 into autowarefoundation:main Jan 12, 2023
@kosuke55 kosuke55 deleted the feat/pull_over_out_no_planner_error branch January 12, 2023 16:00
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Jan 12, 2023
…nners (autowarefoundation#2644)

feat(behavior_path_planner): error messsage when no pull over/out planner

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jan 13, 2023
…nners (autowarefoundation#2644) (#242)

feat(behavior_path_planner): error messsage when no pull over/out planner

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants