Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix lane change path validation logic #2873

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Feb 13, 2023

Signed-off-by: Fumiya Watanabe rej55.g@gmail.com

Description

Before this change, external request lane change module outputs improper path.
In this change, I fixed the validation logic of lane change path.

Note:
lane_change_required_distance is equal to 0 in lane change module.
So, this change effects to external request lane change module only.

Related links

Tests performed

Tested by planning simulator.

Before
Screenshot from 2023-02-13 11-05-36

After
Screenshot from 2023-02-13 11-26-10

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 11.71% // Head: 11.71% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (81627c2) compared to base (00b97e4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2873      +/-   ##
==========================================
- Coverage   11.71%   11.71%   -0.01%     
==========================================
  Files        1314     1314              
  Lines       91601    91602       +1     
  Branches    24478    24479       +1     
==========================================
  Hits        10727    10727              
- Misses      69689    69690       +1     
  Partials    11185    11185              
Flag Coverage Δ *Carryforward flag
differential 4.67% <0.00%> (?)
total 11.71% <ø> (+<0.01%) ⬆️ Carriedforward from 00b97e4

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rej55 rej55 enabled auto-merge (squash) February 13, 2023 03:28
@rej55 rej55 merged commit 58ee5e4 into autowarefoundation:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants